Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Product List to Match Cymbal Branding/Story #600

Merged
merged 4 commits into from
Sep 23, 2021
Merged

Update Product List to Match Cymbal Branding/Story #600

merged 4 commits into from
Sep 23, 2021

Conversation

NimJay
Copy link
Collaborator

@NimJay NimJay commented Sep 22, 2021 •
edited
Loading

See the "What needs to be done?" section of #574.

Background
According to the Google-internal Cymbal site, Cymbal Shops sells "homewares, electronics, and clothing"

Change Summary
This pull-request:

  • updates the list of products being sold to fits the Cymbal Shops story/brand.
  • update the ads displayed at the bottom of Product pages with the new products.
  • updates some comments that referenced the old products.
  • updates a small test in src/productcatalogservice/server_test.go.

Additional Info

  • The new product list was approved by the Google Cloud Demo and Experiments team designers (see Google-internal Figma prototypes).
  • All new photos were taken by me (@NimJay).
  • We received approval from Google's Open Source Licensing team to use these photos.

@NimJay
Update product list (and images)
0f01d5d 
All new photos were taken by me (Nim).
We received approval from Google's Open Source Licensing team
to use these photos.
@NimJay
Update ads to match new product list
9fe3587
@NimJay
Update comments about product categories
297b45e
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 22, 2021
@NimJay NimJay mentioned this pull request Sep 22, 2021
Closed
5 tasks
@github-actions
Copy link

🚲 PR staged at http://34.75.105.246

@NimJay
Copy link
Collaborator Author

NimJay commented Sep 22, 2021

@bourgeoisor, I've assigned this to you since you're currently on rotation.
Take your time. :)

bourgeoisor
bourgeoisor approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, these new images look great!!

@NimJay NimJay merged commit d2c729d into master Sep 23, 2021
@NimJay NimJay deleted the nimjay-cymbal-branding-products branch September 23, 2021 20:57
D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
@NimJay
Update Product List to Match Cymbal Branding/Story (GoogleCloudPlatfo…
bcc89b4 
…rm#600)

* Update product list (and images)

All new photos were taken by me (Nim).
We received approval from Google's Open Source Licensing team
to use these photos.

* Update ads to match new product list

* Update comments about product categories

* Update productcatalogservice/server_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askmeegs askmeegs askmeegs approved these changes

@bourgeoisor bourgeoisor bourgeoisor approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NimJay @askmeegs @bourgeoisor @googlebot